Skip to content

Make ArmPassManager aware of TosaSpecification #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarandersson8218 merged 1 commit into from
Jan 16, 2025
Merged

Make ArmPassManager aware of TosaSpecification #7668

oscarandersson8218 merged 1 commit into from
Jan 16, 2025

Conversation

@oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Jan 15, 2025

Summary

  • Pass TosaSpecifcation to ArmPassManager. Based on this the PassManager can decide which passes should be run.
  • Also adds docstrings and renames some passes.

@oscarandersson8218
Make ArmPassManager aware of TosaSpecification
bf2dd7a 
- Pass TosaSpecifcation to ArmPassManager. Based on this the
 PassManager can decide which passes should be run.
- Also adds docstrings and renames some passes.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Idbbae8d041d3e4c105187fecd54a334cbf142a78
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7668

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job

As of commit bf2dd7a with merge base 01d526f (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 15, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2025
digantdesai
digantdesai approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a comment about the big pass table.

@oscarandersson8218 oscarandersson8218 merged commit a4def9f into pytorch:main Jan 16, 2025
104 of 111 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@oscarandersson8218 @YIWENX14
Make ArmPassManager aware of TosaSpecification (#7668)
8121ee2 
- Pass TosaSpecifcation to ArmPassManager. Based on this the
 PassManager can decide which passes should be run.
- Also adds docstrings and renames some passes.

Signed-off-by: Oscar Andersson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarandersson8218 @digantdesai @facebook-github-bot